Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade nwaku image to v0.26.0 #74

Merged
merged 1 commit into from
Mar 12, 2024
Merged

chore: Upgrade nwaku image to v0.26.0 #74

merged 1 commit into from
Mar 12, 2024

Conversation

NagyZoltanPeter
Copy link
Contributor

... and utilize Waku Rest reference page access to REST API.

v0.26.0 of nwaku is out!

@NagyZoltanPeter NagyZoltanPeter self-assigned this Mar 11, 2024
gabrielmer
gabrielmer approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

SionoiS
SionoiS approved these changes Mar 11, 2024
View reviewed changes
Copy link

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful thanks for it!

Ivansete-status
Ivansete-status approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for it! Shall we also change the retention policy to "size:10GB", f.e. ?

@NagyZoltanPeter
Copy link
Contributor Author

Thanks for it! Shall we also change the retention policy to "size:10GB", f.e. ?

Well it is a good question. I think most of the volunteers who start playing with it might find it "too expensive" to say I need to provide 10G for such feature, maybe we should start with less and provide some external shell variable to override the default. WDYT?

@Ivansete-status
Copy link
Contributor

Thanks for it! Shall we also change the retention policy to "size:10GB", f.e. ?

Well it is a good question. I think most of the volunteers who start playing with it might find it "too expensive" to say I need to provide 10G for such feature, maybe we should start with less and provide some external shell variable to override the default. WDYT?

Very good point! Go ahead with that approach :) 🙌

@NagyZoltanPeter
Copy link
Contributor Author

Thanks for it! Shall we also change the retention policy to "size:10GB", f.e. ?

Well it is a good question. I think most of the volunteers who start playing with it might find it "too expensive" to say I need to provide 10G for such feature, maybe we should start with less and provide some external shell variable to override the default. WDYT?

Very good point! Go ahead with that approach :) 🙌

Ok, let me add in a separate PR.

@NagyZoltanPeter NagyZoltanPeter merged commit f269a8e into master Mar 12, 2024
@NagyZoltanPeter NagyZoltanPeter deleted the bump-image-to-v0.26 branch March 12, 2024 08:44
@hsaidc hsaidc mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@gabrielmer gabrielmer gabrielmer approved these changes

@SionoiS SionoiS SionoiS approved these changes

Assignees

@NagyZoltanPeter NagyZoltanPeter

Labels
None yet
Projects
Waku
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NagyZoltanPeter @Ivansete-status @SionoiS @gabrielmer